-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a ConnectRouter
based Transport
#548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some test coverage would be nice. Also see comments below:
ConnectRouter
based http clientConnectRouter
based Transport
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really ran this code through its paces with https://github.com/bufbuild/connect-query/commits/dimitri/mock-transport and it's working amazingly!
Add a
UniversalHandler
based http client. Also addcreateRouterTransport
.This can be used to create mock/stub handlers for testing client and also to test backends without needed to run a server.